Imports patch #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development
This reverts commit 2966097.
|
Would it be possible for you to check if these export changes fix the menu ui issue? Here's some example code for you to try it with #3 You might have to change imports in that example because this uses the old style, but the code itself must work. |
|
It's working with the example code https://i.gyazo.com/8c0b3ef4ffc5be8ca67b3d24e56a1cbc.mp4 However, if you go into a submenu the submenu cannot be closed. This happens in both 1.1.1 and this PR. Pressing 'm' while in a submenu simply reopens the main menu |
|
Thanks. I will push this to npm in an hour or two |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the import errors on 1.2.0. Should note that I haven't tested NativeUI after making these changes