Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support implicit usage in Dynosaur and Scanamo conversions #228

Closed
wants to merge 1 commit into from
Closed

Support implicit usage in Dynosaur and Scanamo conversions #228

wants to merge 1 commit into from

Conversation

jrduncans
Copy link
Contributor

No description provided.

@jrduncans jrduncans mentioned this pull request Apr 10, 2022
Closed
d2a4u
d2a4u approved these changes Apr 11, 2022
View reviewed changes
Copy link
Owner

@d2a4u d2a4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@d2a4u
Copy link
Owner

d2a4u commented Apr 11, 2022

there was an issue with scalacOptions where -Ypartial-unification was missing for scala 2.12 which caused mapN to fail compilation. I have fixed it but don't have permission to push to your branch so I created a new branch, fix and merge it: #231

@d2a4u d2a4u closed this Apr 11, 2022
@jrduncans jrduncans deleted the dynosaur-implicit branch April 12, 2022 00:51
@jrduncans
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d2a4u d2a4u d2a4u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrduncans @d2a4u