Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVIF images with a gain map #1735

Closed
vaisest opened this issue Nov 28, 2023 · 4 comments
Closed

AVIF images with a gain map #1735

vaisest opened this issue Nov 28, 2023 · 4 comments

Comments

@vaisest
Copy link

vaisest commented Nov 28, 2023

System information:

  • Windows OS version: 11 23H2 22631.2715
  • ImageGlass version: 9.0.7.1125

To Reproduce

Steps to reproduce the behavior:

  1. Load AVIF gain map image

Actual behavior:

image

Expected behavior:

I would expect the image to be displayed.

Additional context:

I believe Google's Ultra HDR format refers to the same HDR format of embedding a gain map. JPEG images however were displayed, although only in SDR.

Here's Adobe's documentation on gain maps, which contains sample images.

@d2phap
Copy link
Owner

d2phap commented Nov 29, 2023

Your AVIF file contains 2 frames, by default, ImageGlass will read all frames with MagickNET, convert to WicBitmapDecoder, and render on the viewer. Currently, getting frame with WicBitmapDecoder throws that error. It seems Windows WIC does not support it somehow.

You can make it works by adding .avif to the SingleFrameFormats setting to force ImageGlass reading only the first frame:

// in igconfig.json file
"SingleFrameFormats": ".avif;.heic;.heif;.psd;.jxl;",

@vaisest
Copy link
Author

vaisest commented Nov 29, 2023

Is actual support planned? These Gain Map images will probably start to get much more popular as e.g. the Google Pixel 8 added support for them.

d2phap added a commit that referenced this issue Nov 29, 2023
@d2phap
Copy link
Owner

d2phap commented Nov 29, 2023

I will need to spend more time to check further. So no fixed plan.

@d2phap
Copy link
Owner

d2phap commented Dec 12, 2023

v9.0.8.1208 already fixes this by adding .avif to the SingleFrameFormats by default. That's all I can fix for now

@d2phap d2phap closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants