Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkered background is too small on 4K #374

Closed
philiparvidsson opened this issue Jul 11, 2018 · 9 comments
Closed

checkered background is too small on 4K #374

philiparvidsson opened this issue Jul 11, 2018 · 9 comments

Comments

@philiparvidsson
Copy link

System information:

  • Windows OS version: 10 (1803)
  • ImageGlass version: 5.1.5.20 [Portable]

Describe the bug:

The checkered background is too small on 4K screens.

Expected behavior:

The checker background should be scaled according to Windows display settings.

To Reproduce

Steps to reproduce the behavior:

  1. Buy a 4K monitor
  2. Connect it to your computer.
  3. Start ImageGlass.
  4. Enable checkered background.

Screenshots:

image

Additional context:

n/a

@d2phap
Copy link
Owner

d2phap commented Jul 11, 2018

Hi @philiparvidsson
Thanks for the issue.

I need some more information:

  • What is your screen DPI? You can check by open Windows Settings > System > Display, scroll to the Scale and Layout section.

Thanks

@philiparvidsson
Copy link
Author

@d2phap

I will check ASAP (not currently at that computer). It's a Dell U2718Q monitor, 27-inch 4K panel with scaling set to 200% in Windows.

@d2phap
Copy link
Owner

d2phap commented Jul 12, 2018

Thanks, I will add this feature in the next release

@d2phap d2phap added this to the 5.1.5.20 milestone Jul 12, 2018
d2phap added a commit that referenced this issue Jul 18, 2018
…red background grid color follow the background color

#374
@d2phap
Copy link
Owner

d2phap commented Jul 18, 2018

Hi @philiparvidsson
Your feature request was implemented.
The size of grid will be auto-adjusted by DPI scaling number.

You can try the latest build 5.1.7.18 here: https://imageglass.org/moon

@philiparvidsson
Copy link
Author

@d2phap, that's great. Did you also adjust the size of the image according to DPI scaling? 100% zoom should also be scaled according to DPI, otherwise 100% zoom will look tiny on high DPI monitors. I.e., not only the background should be scaled, but also the image.

@d2phap
Copy link
Owner

d2phap commented Jul 28, 2018

The image size cannot be adjusted. It will be blurred, and the viewer should respect the actual size of image.

One example, you can compare the png image by Google Chrome and ImageGlass to see the differences.

@philiparvidsson
Copy link
Author

@d2phap you should have a look at how windows photos app does it. it doubles the pixel size if dpi scaling is set to 200% to keep the image the same size on the screen.

@d2phap
Copy link
Owner

d2phap commented Jul 29, 2018

Hi @philiparvidsson
Sorry but that is the big problem of Windows Photo app.

Reddit users complain its blurry issue.
PNG/JPG... are not like vector format, it's pixel-based format.

@philiparvidsson
Copy link
Author

just tried the new version - great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants