Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Close after edit button #413

Closed
eliaspizarro opened this issue Aug 31, 2018 · 8 comments
Closed

[Feature] Close after edit button #413

eliaspizarro opened this issue Aug 31, 2018 · 8 comments

Comments

@eliaspizarro
Copy link

Is your feature request related to a problem? Please describe.

Maybe, when you click on edit, the photo is still in use by imageglass, so yo need to close imageglass

Describe the solution you'd like

Close after press edit

@d2phap
Copy link
Owner

d2phap commented Sep 3, 2018

Is it really necessary to auto-close?
Just press ESC to close?

@fire-eggs
Copy link
Collaborator

Just to be clear, @eliaspizarro is saying he needs to close ImageGlass in order to release a file lock on the image.

I may have seen this myself, just hadn't investigated.

Files need to be opened in Read-only and Shared modes. Apparently, we are opening them in Read-Write and/or Exclusive modes.

@fire-eggs
Copy link
Collaborator

@eliaspizarro -
What file format(s) are you trying to edit?

So far, I can edit jpg and png files via IG, using Paint, with no issue.

@fire-eggs
Copy link
Collaborator

Digging a little further, I'm pretty sure in most cases that IG does not lock the image file. There is a lock on some or all of the folders when viewing images in sub-folders (a side-effect of watching for changes).

So I'll need more details on how to reproduce this ...

@xmha97
Copy link
Contributor

xmha97 commented Jul 21, 2019

Is it really necessary to auto-close?
Just press ESC to close?

Hi @d2phap
I need this feature.
Please add this feature in next release.
Thanks <3

@Crivens
Copy link

Crivens commented Dec 23, 2019

Yeah I would love this feature. I only use ImageGlass as a quick image previewer before maybe editing it in PSP (slow to load). I don't need ImageGlass to hang around after I've entered PSP, so making it auto close would be excellent.

@d2phap d2phap added this to Potential tasks in 8.0 via automation Jul 10, 2020
@d2phap d2phap moved this from Potential tasks to Tasks in 8.0 Nov 3, 2020
@d2phap d2phap added this to the Issues 7.6.4.30 milestone Nov 3, 2020
d2phap added a commit that referenced this issue Nov 3, 2020
@d2phap d2phap moved this from Tasks to In progress in 8.0 Nov 3, 2020
@d2phap
Copy link
Owner

d2phap commented Nov 9, 2020

This feature is ready in IG Moon: https://imageglass.org/moon
You need to check on option in Settings > Edit tab:

image

@d2phap d2phap moved this from In progress to Reviewing in 8.0 Nov 9, 2020
@xmha97
Copy link
Contributor

xmha97 commented Nov 9, 2020

Thanks 🙏

@d2phap d2phap closed this as completed Nov 12, 2020
8.0 automation moved this from Reviewing to Done Nov 12, 2020
@StevenLOL StevenLOL mentioned this issue Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
8.0
  
Done
Development

No branches or pull requests

5 participants