Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make title bar themeable #595

Closed
marnick-s opened this issue Aug 3, 2019 · 15 comments
Closed

Make title bar themeable #595

marnick-s opened this issue Aug 3, 2019 · 15 comments

Comments

@marnick-s
Copy link

marnick-s commented Aug 3, 2019

I dont know if this is possible, but it would be a nice feature if you could add the option to give the Windows toolbar a color that matches the background of the installed ImageGlass theme.

With the toolbar I mean this: https://i.imgur.com/fbCryTH.png

image

@kid1412621
Copy link

and stick image to desktop fixed

@d2phap
Copy link
Owner

d2phap commented Dec 16, 2019

Hi @kid1412621
What do you mean about "and stick image to desktop fixed" ?
Thanks

@kid1412621
Copy link

kid1412621 commented Dec 16, 2019

@d2phap
my bad, I mean, a feature allows user to pin images to desktop(above wallpaper, or even other windows) like a sticker without titlebar. And free to drag around. It will be greatly helpful for some cheat-sheets or memos. I searched for half of a day. But there is no available for Windows 10.

@d2phap
Copy link
Owner

d2phap commented Dec 16, 2019

@kid1412621
Since IG Moon supports Frameless and Window fit mode, you can do it with the Keep window always on top option. https://imageglass.org/moon

@kid1412621
Copy link

kid1412621 commented Dec 17, 2019

@d2phap cool, just checked it out. That's exactly what I'm looking for! And two more requests: ability to freeze the window(in order to prevent from pressing ESC accidentally ) , drag freely (just found out holding shift will work) and lock the ratio when adjusting the window size.

@d2phap
Copy link
Owner

d2phap commented Dec 17, 2019

@kid1412621

ability to freeze the window(in order to prevent from pressing ESC accidentally )

You can uncheck the option:
image

lock the ratio when adjusting the window size.

The zoom modes: scale to fit / scale to fill / lock zoom ratio may fit you
image

@kid1412621
Copy link

kid1412621 commented Dec 17, 2019

@d2phap u r soooo kind, thx.
But there is a little different from what I want.
I want to disable ESC only in the frameless mode. Moreover freeze future should disable other interactions with image, eg, double click to zoom. Only certain combination of keyboard shortcuts or mouse event could unfreeze.
And I mean lock the ratio of the window, not the picture. Just in case this situation happens
image
Wanna window size fit image perfectly, currently those options cannot solve this.

@fire-eggs
Copy link
Collaborator

Moved @kid1412621 's hijacking feature requests to a new issue.

@Unknow0059
Copy link

Unknow0059 commented Jun 27, 2020

Ever since Windows 8.1 users have been able to change the color of the title bar, and on Windows 10 this is the procedure:
image
This should suffice in the (possibly long) meantime.

@d2phap
Copy link
Owner

d2phap commented Jun 30, 2020

IG uses native Windows title bar, you can just change its color as @Unknow0059 mentioned.
I want to keep IG simple so I will not implement this.

@DarkotHub
Copy link

DarkotHub commented Dec 6, 2021

IG uses native Windows title bar, you can just change its color as @Unknow0059 mentioned. I want to keep IG simple so I will not implement this.

This is not a very reasonable solution as far as the user is concerned. What you're saying is that, if someone wanted a dark title bar, then they'd have to sacrifice their current accent colour, just to get it on this ONE app.

For me personally, I don't like applying an accent colour to title bars. I keep that setting off because I find it off-putting on most apps. But as things are now, if I don't want to have a glaring white title bar on ImageGlass, that means that I have to go with the equally unappealing option of having the same, boring dark colour across all of my applications (including the file explorer).

Tons of apps have a setting to choose between a dark and light mode. I have a hard time believing it would make IG unreasonably complex to do that at least.

@duckfist
Copy link

duckfist commented Jan 5, 2022

Since this is .NET Core, it's quite easy to do actually. WindowStyle must be set to "None" and a custom window style must be created, with a custom title bar and maximize/minimize buttons. This is standard procedure for any WPF desktop app that wants to look even remotely professional. The style can then be easily used by every window in the application. Dev is just lazy and still uses Windows Forms with default window styles (lol). Also, by setting the Accent Color to black in Windows Settings JUST to get dark title bars, you make text and other effects difficult to see throughout other areas of Windows since it is now black on black when using Dark Theme.

I guess my search for a competent .NET Core image viewer continues.

@fire-eggs
Copy link
Collaborator

Since this is .NET Core, it's quite easy to do actually.

Since it's "quite easy", why don't you submit a fix rather than be insulting?

The "Dev" (not me, BTW) has a real job and a real life and has to juggle priorities like any human being.

@d2phap
Copy link
Owner

d2phap commented Jan 6, 2022

Thanks @fire-eggs
@duckfist You seem know how to implement it so well, just this, just that,... please submit a fix. Thank you.

d2phap added a commit that referenced this issue Nov 3, 2022
@d2phap d2phap added this to the v9.0 beta 3 milestone Nov 3, 2022
d2phap added a commit that referenced this issue Nov 3, 2022
@d2phap
Copy link
Owner

d2phap commented Nov 3, 2022

Dark mode for title bar is supported in v8.7.11.6. You may need to update your theme packs: https://imageglass.org/themes.

If you check the option Show colour in Start, taskbar, action centre and title bar in Windows Settings, the title bar will use the accent color.

@d2phap d2phap removed this from the v9.0 beta 3 milestone Nov 3, 2022
@d2phap d2phap added this to the v8.7 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
V9 - Beta 3
Awaiting triage
Development

No branches or pull requests

7 participants