-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizable toolbar icon size #879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for very quick implementation!
There are some comments, please take a look.
I just looked at the code right now. I will pull this PR, compile, and run it tomorrow.
The designer diff is so large because Phap works at 150% screen magnification / 144DPI. Using any other configuration causes the GUI design to become completely messed up [the designer changes all the position and sizing info]. There is some more detail in the wiki at |
Wow, thank you a lot! I'd finish it by myself, but have no free time till end of the week. And thank you for the review, guys. @d2phap @fire-eggs |
thanks @gsomix ! |
Closes #513
I have introduce a lot of parameter passing to take new icon size setting into account. I'm also not sure why designer diff is so big. Auto-edits from Visual Studio 2019?
Check list:
After merge: