Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable toolbar icon size #879

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Customizable toolbar icon size #879

merged 2 commits into from
Oct 8, 2020

Conversation

gsomix
Copy link
Contributor

@gsomix gsomix commented Oct 3, 2020

Closes #513

I have introduce a lot of parameter passing to take new icon size setting into account. I'm also not sure why designer diff is so big. Auto-edits from Visual Studio 2019?

Check list:

  • Add icon sizesetting into config
  • Add controls to UI
  • Pass the setting to theme loader, DPI scaling and UI update methods
  • Add new entry to language packs
  • Manually test changes

After merge:

  • Create new issue about wrong tab order in setting form
  • Create new issue about localization for icon size setting

1
2

Copy link
Owner

@d2phap d2phap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for very quick implementation!
There are some comments, please take a look.
I just looked at the code right now. I will pull this PR, compile, and run it tomorrow.

@fire-eggs
Copy link
Collaborator

The designer diff is so large because Phap works at 150% screen magnification / 144DPI. Using any other configuration causes the GUI design to become completely messed up [the designer changes all the position and sizing info].

There is some more detail in the wiki at

@d2phap d2phap merged commit f55398b into d2phap:develop Oct 8, 2020
@gsomix
Copy link
Contributor Author

gsomix commented Oct 8, 2020

Wow, thank you a lot! I'd finish it by myself, but have no free time till end of the week.

And thank you for the review, guys. @d2phap @fire-eggs

@d2phap
Copy link
Owner

d2phap commented Oct 8, 2020

thanks @gsomix !
I just got free time today (due to sickness 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to change toolbar button size
3 participants