Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 4 and 8 digit hex codes #67

Merged
merged 4 commits into from Sep 25, 2019
Merged

Conversation

zerovox
Copy link
Contributor

@zerovox zerovox commented Sep 19, 2019

Fixes #60

Wasn't sure how to concisely update the documentation, as this doesn't add support for the full css 4 spec, which now supports gray, hwb, lab, lch and others.

@mbostock

@mbostock mbostock merged commit 6d5e89c into d3:master Sep 25, 2019
@mbostock
Copy link
Member

Thanks for the contribution.

One question I have is now whether color.formatHex() should return an 8-digit hexadecimal when the color has opacity != 1.0. But that probably would want a major version bump as this isn’t strictly backwards-compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support for 4- and 8-digit hexadecimal codes.
2 participants