Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the package as having no side effects #32

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Conversation

stof
Copy link
Contributor

@stof stof commented Sep 27, 2019

No description provided.

@Fil Fil self-requested a review June 3, 2020 14:52
@stof
Copy link
Contributor Author

stof commented Jun 25, 2020

@Fil anything left to get this merged, as you approved it 22 days ago ?

@Fil
Copy link
Member

Fil commented Jun 25, 2020

We're currently doing a complete review of all the pending issues and PRs in the D3 project—this will be merged soon(ish).

@Fil Fil merged commit 270bbcb into d3:master Jul 10, 2020
@stof stof deleted the no_side_effects branch November 10, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants