Use delaunator v5; adopt type=module #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te triangles created by points of the hull that are almost exactly aligned. The "circumcenter" of such a triangle is a point at the infinite, in the direction orthogonal to the hull. It must also be "away from the center". But we can't rely on the sign of *ab*, since it's itself a difference of two products and can be of the wrong sign, leading to a ray that sometimes goes in the opposite direction. To overcome this problem, we use the first point of the first triangle as a guide to tell us which way is "away from the center".
mbostock
reviewed
Apr 23, 2021
There was a problem hiding this comment.
We should remove the esm dependency if we are adopting type: module, and we should add an engines: {"node": ">=12"} restriction. I’m also inclined to switch to mocha for testing, since mocha’s test runner already supports ES modules. And I’d also upgrade our other major dependencies at the same time (eslint and rollup have new major versions).
In short, let’s decide on a consistent strategy for the D3 modules and adopt it universally. Related d3/d3-format#112
Edit: so, mostly what’s in #115, but with mocha instead of tape + tape-await + esm.
follow changes in d3-format: * type=module * add exports * remove zip * update dependencies
Fil
changed the title
|
@mbostock this PR is ready; I don't think I have the rights to switch the default branch to |
mbostock
approved these changes
Apr 26, 2021
|
I’ve renamed to main. |
mourner
reviewed
Apr 26, 2021
mbostock
reviewed
Apr 26, 2021
Co-authored-by: Mike Bostock <mbostock@gmail.com>
mbostock
reviewed
Apr 26, 2021
Co-authored-by: Mike Bostock <mbostock@gmail.com>
closes #130
Co-authored-by: Mike Bostock <mbostock@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
This is a story in 4 images
https://next.observablehq.com/d/62b5c48194cba6b2
delaunator v5 ➘
delaunator v5 + ignore ab ➘
delaunator v5 + direction ➘
see 3d26401 for the detailed explanation.
Fixes #119.