-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global d3 object is overwritten #29
Comments
Perhaps it's to do with the Rollup upgrade in this commit ad89faa, which changed it from 0.41 to 0.49. Looking through the Rollup CHANGELOG, I think the culprit is this change from 0.44:
Discussion of this feature is in rollup/rollup#827 It looks like this can be fixed by setting Rollup's |
Sorry about this! I forgot about this change when upgrading Rollup. |
Thanks for the fix! |
As of release 1.0.6, d3-dsv has this at the top:
The effect is that global.d3 is reset, removing anything that previously loaded modules put there. All the other modules have
global.d3 = global.d3 || {}
The problem is present both in d3-dsv.zip for version 1.0.6 on github, and in https://d3js.org/d3-dsv.v1.js
The text was updated successfully, but these errors were encountered: