Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set clipCircle precision to 2 degrees #282

Merged
merged 4 commits into from
Mar 12, 2024
Merged

set clipCircle precision to 2 degrees #282

merged 4 commits into from
Mar 12, 2024

Commits on Apr 28, 2023

  1. default geoCircle precision to 2 degrees 

    Results in 180 control points instead of 60 (⨉3). The error is quadratic with the precision, with the worst case (for a parallel) being at latitude 45°. Under this new setting, the maximum error is now ~484m, vs. 4.365km with precision 6°.
https://observablehq.com/@d3/geocircle-error
    @Fil
    Fil committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    158e2ae View commit details
    Browse the repository at this point in the history

  2. document

    @Fil
    Fil committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    c02a460 View commit details
    Browse the repository at this point in the history

  3. refine clipCircle precision, from 6 degrees to 2 degrees 

    following #281

(note that for clipCircle the precision is not modifiable by the user)

Manually rechecked each of the tests that are (slightly) modified as a consequence
    @Fil
    Fil committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    32bc469 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Merge branch 'main' into fil/clipCircle-precision

    @mbostock
    mbostock committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0b0fb82 View commit details
    Browse the repository at this point in the history