Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack layout should allow parent padding? (“Margin”?) #7

Closed
mbostock opened this issue Oct 21, 2015 · 8 comments
Closed

Pack layout should allow parent padding? (“Margin”?) #7

mbostock opened this issue Oct 21, 2015 · 8 comments

Comments

@mbostock
Copy link
Member

Related d3/d3#2536; see demo.

@mbostock
Copy link
Member Author

I’m not sure about the name “margin”; maybe it’s worth having sibling padding and parent padding? Or maybe padding should automatically apply to the parent circle, not just the siblings.

@larskotthoff
Copy link

I like the idea of having just one padding that applies to both parent and siblings.

@mbostock
Copy link
Member Author

Seems reasonable to me, too.

@mbostock
Copy link
Member Author

Related question: Should the padding be configurable per node? Seems like you could compute the padding per node if it is specified as a function, and it would apply to padding between that node and its children (parent-child padding), and amongst its children (sibling padding).

@mbostock
Copy link
Member Author

Related #9.

@larskotthoff
Copy link

Yep, it would certainly be good to have it configurable per node as well. Sounds like d3/d3#2473 would be a more general solution to this.

@mbostock
Copy link
Member Author

Fixed.

@mbostock
Copy link
Member Author

screen shot 2016-03-22 at 1 07 01 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants