Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #23

Merged
merged 5 commits into from
May 25, 2017
Merged

Update README #23

merged 5 commits into from
May 25, 2017

Conversation

tomwanzek
Copy link
Contributor

  • Align API Documentation with source code.
  • Add missing methods size and link
  • Remove inapplicable references to accessor functions
  • Provide information about nodes and links
  • Clarify how links can be initialized based on numeric index into nodes array.

@tomwanzek
Update README
6f34184 
* Align API Documentation with source code.
 * Add missing methods `size` and `link`
* Remove inapplicable references to accessor functions
* Provide information about `nodes` and `links`
* Clarify how links can be initialized based on numeric index into `nodes` array.
@tomwanzek tomwanzek mentioned this pull request Apr 21, 2017
Closed
@tomwanzek tomwanzek mentioned this pull request Apr 28, 2017
Merged
9 tasks
ravibha
ravibha approved these changes Apr 28, 2017
View reviewed changes
Copy link

@ravibha ravibha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@tomwanzek
Fix HTML syntax highlighting
e149867 
* Incorporate the fix to HTML syntax highlighting proposed by @curran in unmerged PR #20
@tomwanzek
Copy link
Contributor Author

For completeness I have added the fix to using HTML syntax highlighting proposed by @curran in PR #20.

@mbostock or @arankek could you kindly review/merge this documentation PR. Let me know, if you require any changes.

@tomwanzek
Copy link
Contributor Author

@mbostock @arankek ping?

@mbostock mbostock merged commit da7b1a0 into d3:master May 25, 2017
@mbostock
Copy link
Member

I made some tweaks and merged. I think I’m finally motivated to take a pass over the API as well.

@tomwanzek tomwanzek deleted the api-doc-revisited branch May 26, 2017 15:54
@tomwanzek
Copy link
Contributor Author

@mbostock Thanks, the changes in the underlying API/implementation are great. I.p. since the link shape is now used!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravibha ravibha ravibha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomwanzek @mbostock @ravibha