Remove dependencies on jStat, Moment and Moment-Range #83
Conversation
…s may break some of the data filters that filter weekends;
.filter(function (moment) { return !(moment.day() === 0 || moment.day() === 6); })
should be changed to:
.filter(function (date) { return !(date.getDay() === 0 || date.getDay() === 6); })
Candlestick OHLC Relative Strength Index
|
Looks ok. Is the ternary op on line 52 of dataGenerator inverted? Also the sum of uniform's on line 83 is probably good enough for our purposes, but keep the other method if you like. |
|
You are absolutely correct it was, well spotted. We can leave both in and then maybe allow the user to select it with a property further down the line. |
Remove dependencies on jStat, Moment and Moment-Range
|
The app and recreations are broken and need the newly built files to work. The Gridlines example still links to some of the removed files. |
|
Ah, I didn't build the dist files and check them in as I haven't installed grunt on my machine at home. If somebody could do that there or I'll sort it tomorrow in the office. |
|
No worries, I'll do that now :) |
|
Done. From: Mark Jose [mailto:notifications@github.com] Ah, I didn't build the dist files and check them in as I haven't installed grunt on my machine at home. If somebody could do that there or I'll sort it tomorrow in the office. — |
I've also been through as much as I can a checked all examples and documentation for references to the above dependencies.