Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: new Schema as typescript interface instead of JSON object #11

Merged
merged 14 commits into from
Mar 24, 2021

Conversation

maastrich
Copy link
Contributor

No description provided.

NathanBonnot
NathanBonnot previously approved these changes Mar 13, 2021
jess-sys
jess-sys previously approved these changes Mar 15, 2021
Copy link
Contributor

@jess-sys jess-sys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code.

Maybe we want to use Clovis' lib (typescript-is) ?

Still need to fix package.json/yarn.lock

@jess-sys
Copy link
Contributor

Fixed conflicts.

@maastrich
Copy link
Contributor Author

maastrich commented Mar 15, 2021

Clean code.

What do you mean ?

Maybe we want to use Clovis' lib (typescript-is) ?

A choice still has to be made but for the moment the decorators are not in use

Still need to fix package.json/yarn.lock

Thanks for fixing

@maastrich maastrich changed the title add: new Schema as typescript class instead of JSON object add: new Schema as typescript interface instead of JSON object Mar 17, 2021
@super-bunny super-bunny merged commit 352cc13 into dev Mar 24, 2021
@super-bunny super-bunny deleted the rework/schema branch March 24, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants