Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for in loop symbols #290

Merged
merged 2 commits into from
May 22, 2020
Merged

fix for in loop symbols #290

merged 2 commits into from
May 22, 2020

Conversation

ozanh
Copy link
Contributor

@ozanh ozanh commented May 22, 2020

Closes #288

@d5
Copy link
Owner

d5 commented May 22, 2020

Not part of the change, but let's correct the following comment in the same function:

// ":it" is a local variable but will be conflict with other user variables
// because character ":" is not allowed.

should be

// ":it" is a local variable but it will not conflict with other user variables
// because character ":" is not allowed in the variable names.

@d5
Copy link
Owner

d5 commented May 22, 2020

Great work, @ozanh

@d5 d5 merged commit e059953 into d5:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants