-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict caused by typedef SSIZE_T ssize_t;
#137
Comments
Hi @p0358 - thanks for reporting the bug. It's an interesting problem! While checking Actually |
@d99kris If you want to keep your typedef, I suggest to move it into your rapidcsv namespace. That should avoid conflicts with potential typedefs in other headers. |
Thanks for the suggestion @Sven-HP - that is true! But I think I'm more inclined to drop the typedef and simply use a standard integer type. I'd prefer if portable apps would not need stuff like I've been thinking about which type to use, and I think regular |
I've created a PR #139 for switching ssize_t usage to int. Feel free to provide feedback on the change in the review. If there are no major concerns I will proceed to merge it next weekend probably. |
fixes #137 - switch ssize_t usage to int
Thanks for checking the PR @Sven-HP! This issue should be fixed now. Please let me know if you still encounter any issues @p0358. Thanks. |
Description:
There's this line in rapidcsv:
However some codebases that include for example nghttp2 may have already set up ssize_t as a macro on project level.
The solution is to check
#ifndef ssize_t
before trying to definessize_t
, otherwise we'll get an error that we're trying to redefine a base type.How to reproduce it:
Environment:
The text was updated successfully, but these errors were encountered: