Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix #140: add two setCell methods #141

Conversation

micrenda
Copy link

@micrenda micrenda commented May 8, 2023

This pull request fixes this issue

@d99kris
Copy link
Owner

d99kris commented May 8, 2023

Hi @micrenda - thanks for contributing!
Will take a closer look before merging - probably in the weekend, but yes it likely makes sense to add these.

@d99kris d99kris self-assigned this May 13, 2023
@d99kris d99kris changed the base branch from master to integrate-add-setcells-methods May 13, 2023 04:41
@d99kris d99kris changed the base branch from integrate-add-setcells-methods to integrate-add-setcell-methods May 13, 2023 04:43
@d99kris d99kris changed the title bugfix #140: add two setCell methods fixes #140 - add two SetCell methods for consistency with GetCell May 13, 2023
@d99kris d99kris changed the title fixes #140 - add two SetCell methods for consistency with GetCell bugfix #140: add two setCell methods May 13, 2023
@d99kris d99kris merged commit c682d40 into d99kris:integrate-add-setcell-methods May 13, 2023
3 checks passed
@d99kris
Copy link
Owner

d99kris commented May 13, 2023

Hi again, I've merged the PR as-is to an integration branch d99kris:integrate-add-setcell-methods and committed follow-up fixes in dd4f601 to add test case, etc. The integration branch will be merged to master via #142 once CI runs complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants