Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two SetCell methods for consistency with GetCell #140

Closed
micrenda opened this issue May 8, 2023 · 1 comment
Closed

Add two SetCell methods for consistency with GetCell #140

micrenda opened this issue May 8, 2023 · 1 comment
Assignees
@d99kris
Labels
bug Something isn't working

Comments

@micrenda
Copy link

micrenda commented May 8, 2023 •
edited
Loading

Description:
We have in total of 4 getCell methods available, as a combination for col/row being specified by name or by id. In the same way, the same combination of setCell methods would be useful, but only two are provided.

I provide a pull request fixing this issue

How to reproduce it:
Check the method signature

Environment:

  • Version: v8.75
  • OS / distro: all
@micrenda micrenda added the bug Something isn't working label May 8, 2023
micrenda pushed a commit to micrenda/rapidcsv that referenced this issue May 8, 2023
bugfix d99kris#140: add two setCell methods
9fdec96
@micrenda micrenda mentioned this issue May 8, 2023
Merged
@d99kris d99kris changed the title Adding two setCell methods Add two SetCell methods for consistency with GetCell May 13, 2023
d99kris added a commit that referenced this issue May 13, 2023
@d99kris
Merge pull request #141 from micrenda/bugfix/140-add-setCell-methods
c682d40 
bugfix #140: add two setCell methods
@d99kris
Copy link
Owner

d99kris commented May 13, 2023

Hi @micrenda - thanks for reporting the issue and providing a pull request!
The fix has been merged now + some follow-up changes, refer to above commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d99kris d99kris

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@micrenda @d99kris