Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Comment options #960

Merged
merged 9 commits into from
Apr 1, 2022
Merged

Add New Comment options #960

merged 9 commits into from
Apr 1, 2022

Conversation

sorat0mo
Copy link
Contributor

@sorat0mo sorat0mo commented Mar 29, 2022

This pull request adds commentbox.io and discussbot in the comment section. Instructions to implement added in _config.yml

Below is a demonstration of the default settings:

CommentsBox:
Y0329_00001

DiscussBot:
Y0329_00001

@sorat0mo sorat0mo changed the title Add CommentBox.io comment section Add New Comment options Mar 29, 2022
Change comments to offer unambiguous descriptions of variables.
@daattali
Copy link
Owner

Thanks for the initiative! I'd be happy to add CommentBox because they offer an extremely simple way to add comments, but there are already many comment systems and I don't see much offered by supporting discussbot as well. Could you remove discussbot? And please update the README as well in the relevant sections

@sorat0mo
Copy link
Contributor Author

Thanks for the initiative! I'd be happy to add CommentBox because they offer an extremely simple way to add comments, but there are already many comment systems and I don't see much offered by supporting discussbot as well. Could you remove discussbot? And please update the README as well in the relevant sections

Done!

@daattali
Copy link
Owner

Could you update the CHANGELOG file too please

@sorat0mo
Copy link
Contributor Author

Could you update the CHANGELOG file too please

Changelog updated as well

@daattali
Copy link
Owner

daattali commented Apr 1, 2022

Thanks!

@daattali daattali merged commit ff07d46 into daattali:master Apr 1, 2022
GuillermoFidalgo pushed a commit to GuillermoFidalgo/OldSite-guillermofidalgo that referenced this pull request Apr 3, 2022
* Init dev branch

* Fix dev branch

* Forgot to add commentbox.html

* Testing discussbot integration

* forgot comments.html

* remove my credentials

* Update _config.yml

Change comments to offer unambiguous descriptions of variables.

* remove discussbot

* Update CHANGELOG.md

Co-authored-by: Karsten Ng <7u9nazbc7@mozmail.com>
SeanieGleason pushed a commit to SeanieGleason/seaniegleason.github.io that referenced this pull request Aug 8, 2023
* Init dev branch

* Fix dev branch

* Forgot to add commentbox.html

* Testing discussbot integration

* forgot comments.html

* remove my credentials

* Update _config.yml

Change comments to offer unambiguous descriptions of variables.

* remove discussbot

* Update CHANGELOG.md

Co-authored-by: Karsten Ng <7u9nazbc7@mozmail.com>
akatekhanh added a commit to akatekhanh/akatekhanh.github.io that referenced this pull request Jan 13, 2024
…hub.io

* 'master' of https://github.com/akatekhanh/akatekhanh.github.io: (40 commits)
  Delete CNAME
  restructure page
  Update CNAME
  Create CNAME
  oop python, OOP overview
  replaced var with const (daattali#1049)
  Add `navbar-var-length` config parameter (daattali#1011)
  more readable format for config file
  Update CHANGELOG.md
  Fixes daattali#765 (daattali#1010)
  add 'edit this page' button; closes daattali#1004
  Update CHANGELOG.md
  Markup home page content lists and tags as lists (daattali#950)
  add news item for hacerrank
  added hackerrank social media network (daattali#978)
  add news item for kaggle social media
  adding kaggle social link (daattali#961)
  add commentbox to readme
  add commentbox to readme
  Add New Comment options (daattali#960)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants