Upgrade to latest visjs Timeline

[daattali]

Currently timevis uses visjs v4.16.1

It'd be nice to update to the most up to date version because they have new features. But there are some issues (and perhaps more, everything needs to be tested thoroughly to make sure nothing breaks):

• When setting options(editable = TRUE), editing items now requires double clicking instead of single clicks, which is a bug. It should still be only a single click to initiate an edit (this is a bug on visjs: [Timeline regression bug] When setting "editable:true" after initialization, items require double clicking instead of single click visjs/vis#3852)
• Dates with times don't work in RStudio (need to add 'T' between the date and the time)
• Times are auto converted to the current user timezone, which results in UI that looks a bit wrong (this is a bug on visjs: [Timeline regression bug] Using a simple date string has timezone issues in 4.21 visjs/vis#3851)

[knbknb]

I have simply replaced timelines_files/vis-4.16.1/vis.min.js and timelines_files/vis-4.16.1/vis.min.css with those versions from timevis-4.21.zip.

It works for me.

Why did I update? Because v4.21 also has more events defined. I need the new onInitialDrawComplete Event which is not available in v4.16. (I don't know when it was added. I didn't find a mention of this event in the visjs release notes)

Just saying, maybe it helps someone who thinks about updating.

[daattali]

Yes it does work. However, there are several non-minor regression bugs in the new visjs timeline version, as I outline in the issue description. Until those are resolved, I would prefer to hold off on updating because these issues mean that many people who will upgrade to the new timevis version will have bugs.

visjs is really great but it's a bit of a shame that bugs don't get addressed and that documentation of new features is very lacking (I also ran into that problem of not knowing when new features got added because they aren't documented)

[daattali]

Merge #70 after upgrading

[strazto]

Are you planning on migrating to the timeline-plus project, when you do upgrade @daattali ?

I experimented with upgrading to the library myself, and found that it was doable but the maintainer's choice of object name (timeline) collided with timevis's timeline.

It's actively maintained, and seems a bit less bloated than the vis.js distro.

I use timevis for work and I find it really really useful, so if you're keen to see some fixes on timeline-plus before you're comfortable upgrading, let me know

[daattali]

I will upgrade to whichever one, as long as the regression bugs I mentioned are fixed. I opened the same issues on timeline-plus repo, if they are fixed over there then yes I will look into switching. But I will not upgrade until the regression bugs are fixed.

[daattali]

Update: I again looked into updating to the latest version, but unfortunately it seems like the bugs I reported to visjs Timeline a few years ago are still unresolved and I cannot update until they are fixed.

[strazto]

So the bugs you've reported have open PRs & will be resolved soon enough.

Personally, I tested the head of the visjs/vis-timeline repo against one of my branches, & I did find that it was hanging my brower.

I'm not sure what's wrong now, but I'm going to do some work to ease the migration (besides the bugfixes I've submitted), because overall the quality of vis-timeline HAS improved, and it has got more features