Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nesting Columns, as in nestedGroups is now supported #70

Closed
wants to merge 15 commits into from

Conversation

strazto
Copy link
Contributor

@strazto strazto commented Jan 30, 2019

Requires updates to vis>=4.18, or else won't change much

@daattali
Copy link
Owner

Thanks @mstr3336

Since this doesn't add any benefit right now (not your own fault as you know), I'm going to leave this open until it becomes relevant

@strazto
Copy link
Contributor Author

strazto commented Jan 30, 2019

Sure - I might go on to investigate the fold/unfold thing.
That's probably more likely to be a problem specific to timevis, given that timevis does implement a few extra ui handlers, and it works well in js only cases.
I was wrong it's a problem with vis.js / timeline plus

@daattali
Copy link
Owner

Sorry I don't actually know what the problem is, I haven't spent any time looking at this, I'm working on another few projects today. If you suspect the problem is because of timevis, maybe try to remove as many of the extra stuff I added and get it to be as basic as possible. timevisBasic might be useful

strazto and others added 4 commits January 31, 2019 14:43
Mainly because I should probably write more regression tests for it before blindly putting it in
I should probably implement a check on the whole column, rather than checking in an apply to check if any are vectors in the col
@strazto strazto closed this Feb 4, 2019
@strazto strazto deleted the fix-nesting branch February 4, 2019 08:37
@strazto strazto restored the fix-nesting branch February 6, 2019 01:30
@strazto strazto deleted the fix-nesting branch February 6, 2019 01:32
@gcarreau
Copy link

Not sure if people are still having problems with the folding/unfolding of nested list but I fixed it by passing the groups to a vis.DataSet using the solution provided in #32

if (opts.groups) {
            var groups = new vis.DataSet();
            opts.groups = fixNestedGroups(opts.groups);
            groups.add(opts.groups);
            timeline.setGroups(groups);
          }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants