This repository has been archived by the owner on Dec 6, 2021. It is now read-only.
Authenticate should use username kwarg if no email is provided.
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for 'username' explicitly in the authenticate() method. Some authenticators (like tastypie's) expect to authenticate() using 'username'.
Woops. Test for new behavior.
…xpect positional args.
See pull request dabapps#45.
|
@tomchristie - I have fixed up #45 and it should be safe to merge this PR. I have tested on Django 1.3 and don't expect things to be any different for later versions. |
tomchristie
added a commit
that referenced
this pull request
Mar 14, 2013
Authenticate should use `username` kwarg if no email is provided.
|
@sfllaw - Thx. 1.6.5 pushed to PyPI |
|
@tomchristie - Awesome! Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to pull request #45.