Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination #242

Merged
40 commits merged into from
Sep 14, 2020
Merged

Pagination #242

40 commits merged into from
Sep 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2018

@ghost ghost added the work in progress label May 2, 2018
@alpower
Copy link
Contributor

alpower commented May 3, 2018

why don't the values on the left correspond with the numbers of controls on the right in the screenshot?

tests/pagination.tsx Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented May 4, 2018

@alpower , if we take the first image as an example, it translates to 'Showing 12 to 15 of 70 total items', in this case, there are 3 items on each page. So there are 24 pages in total. Let me know if there is anything we can do to make it better.

@alpower
Copy link
Contributor

alpower commented May 4, 2018

@nikolaevtomov yeah the first one made sense - it was the second two that didn't.
8-10 of 10 and there are 5 page links - should be 2
3-6 of 7 and there are 3 page links - should be 2

@ghost
Copy link
Author

ghost commented May 4, 2018

@alpower the second one: each page shows 2 items, there are 10 items in total, 10 / 2 therefore 5 pages. (8-10) Currently showing the last page.

the third one: each page shows 3 items, there are 7 items in total, 7 / 3 therefore 2 pages and + 1 for the remainder. (3-6) currently showing the second page. And the last page will show only the remainder which is 1. :)

src/less/pagination.less Outdated Show resolved Hide resolved
src/less/pagination.less Outdated Show resolved Hide resolved
src/less/pagination.less Outdated Show resolved Hide resolved
src/ts/components/pagination/pagination.tsx Show resolved Hide resolved
tests/pagination-display.tsx Outdated Show resolved Hide resolved
tests/pagination.tsx Outdated Show resolved Hide resolved
tests/pagination.tsx Outdated Show resolved Hide resolved
tests/pagination.tsx Outdated Show resolved Hide resolved
tests/pagination.tsx Outdated Show resolved Hide resolved
tests/pagination.tsx Show resolved Hide resolved
src/ts/components/pagination/pagination-display.tsx Outdated Show resolved Hide resolved
src/ts/components/pagination/pagination.examples.md Outdated Show resolved Hide resolved
src/ts/components/pagination/pagination.tsx Outdated Show resolved Hide resolved
src/ts/components/pagination/pagination.tsx Outdated Show resolved Hide resolved
tests/pagination-display.tsx Outdated Show resolved Hide resolved
tests/pagination.tsx Outdated Show resolved Hide resolved
tests/pagination.tsx Outdated Show resolved Hide resolved
tests/pagination.tsx Outdated Show resolved Hide resolved
tests/pagination.tsx Outdated Show resolved Hide resolved
tests/pagination.tsx Outdated Show resolved Hide resolved
JakeSidSmith
JakeSidSmith previously approved these changes Sep 14, 2020
@ghost ghost merged commit 008b701 into master Sep 14, 2020
@ghost ghost deleted the pagination branch September 14, 2020 11:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants