Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for syslog 6 to fern #91

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Conversation

Roguelazer
Copy link
Contributor

See #47

I did this in a way that keeps all syslog-3 and syslog-4 functionality intact.

@BlackDex
Copy link

BlackDex commented Mar 28, 2022

@daboross it would be really great if this could be merged.
This would allow everybody who is using fern together with syslog to get rid of the insecure time crate version!

@BlackDex
Copy link

BlackDex commented Apr 6, 2022

May i suggest that you also update the chrono dependency to omit the oldtime feature?

So instead of:

chrono = { version = "0.4", optional = true }

Use

chrono = { version = "0.4", default-features = false, features = ["clock"], optional = true }

That way the old version of the time crate would be fully gone when using syslog6 🎉

( And after that we only need to hope it gets merged 🤞 )

@daboross
Copy link
Owner

Thank you for this! This looks great. Sorry to let a good PR sit without a review or merge for so long!

Copy link
Owner

@daboross daboross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daboross daboross merged commit 352abfe into daboross:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants