Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature for syslog 5 #47

Closed
daboross opened this issue Nov 14, 2019 · 3 comments
Closed

Add feature for syslog 5 #47

daboross opened this issue Nov 14, 2019 · 3 comments

Comments

@daboross
Copy link
Owner

Should be fairly straightforward, we can do the same thing we did for the syslog3/4 distinction for adding support for syslog 5. Main work is in rewriting full examples to use syslog 5.

There were some things that syslog 3 could do, but syslog 4 couldn't. I can't remember off the top of my head what they were. If syslog 5 fixes these, and is at least as capable as both syslog 3 and 4, we can remove syslog 3/4 examples and leave only actual library code, replacing them entirely with syslog 5 examples.

@Cogitri
Copy link

Cogitri commented Aug 18, 2020

I'm looking into this now, but it seems like there aren't too many changes in v4 vs v5, so I think it'd be fine to just drop support for v4.

Cogitri added a commit to Cogitri/fern that referenced this issue Aug 18, 2020
@daboross
Copy link
Owner Author

daboross commented Sep 1, 2020

While from a new user's perspective, we probably don't need to support 4.0 (and thus I'd be totally fine dropping all documentation for syslog-4), for backwards compatibility, it would be best to keep the feature.

This is the main reason for having the versioned features in the first place - so that we can add new versions without having to release a major version of fern and force everyone to update.

I mean, I would be totally fine with replacing all documentation and examples referencing syslog v4.0 with v5.0, we just still need to keep the feature and support in the codebase for backwards compatibility.

Regardless of that, my apologies for taking this long to respond! I should work on this myself at some point, but in the meantime I'm definitely grateful for PRs :)

@Roguelazer
Copy link
Contributor

syslog 6 is out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants