Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings/2018 09 22 #15

Merged
merged 9 commits into from
Sep 26, 2018
Merged

Conversation

AndyyTaylor
Copy link
Contributor

Hey mate,

First time writing Python typings so lemme know if I stuffed anything :)

I can't find any errors, the only thing I couldn't properly check are return types since PyCharm doesn't wanna resolve them :(

Copy link
Owner

@daboross daboross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! If we just re-add Uint8Array to the __all__ in transcrypt.py and add it to the __all__ in __init__.py this should be good.

src/defs/transcrypt.py Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@AndyyTaylor
Copy link
Contributor Author

Added Uint8Array to all and init :)

@daboross
Copy link
Owner

Looks good :)

Thanks for doing this!

@daboross daboross merged commit 90bd5e2 into daboross:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants