Refactor

[franzs]

Thanks for your work.

There is room for improvement of your script though. 🤓 I commited some suggestions to remove copy'n paste code. Feel free to use them at your will.

[daboynb]

Hi, thank you, currently I'm out of home for vacation and I don't have a PC. I will take a look when I'll be back ;)

[daboynb]

With those changes the script thinks that the json file is always different, it's a pain to look from a phone, I will investigate with a pc😂

[franzs]

No worries. It's not urgent.

It seems there is an empty pif.json as the previous version in your screenshot. Do you have a link to the corresponding workflow run? Then I can have a look at it.

BTW. there are a lot of empty commits. They are created every five minutes and trigger a workflow. Do have an idea where they are from?

[daboynb]

Now it works, idk why ahaha

The empty commits are triggered by me to make the workflow run every 5 min, cron is delayed on GitHub actions.

[franzs]

Thanks for merging. 😃

Let's talk about the empty commits and delayed cron schedules somewhere else. I'll create an issue for this... 🤓