Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-110508 Open in full view #198

Closed
wants to merge 1 commit into from
Closed

LPS-110508 Open in full view #198

wants to merge 1 commit into from

Conversation

balazssk
Copy link

Hi @dacousalr ,

Changed the Web Content Display's View History icon to open in full view instead of a popup.

Can you please review?
https://issues.liferay.com/browse/LPS-110508

Thanks,
Balázs

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@dacousalr
Copy link
Owner

Just started reviewing :)

@dacousalr
Copy link
Owner

ci:test:sf

@dacousalr
Copy link
Owner

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes 7 seconds 97 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 789aebc2aa941b0ea2cebe1ade1a09972d10cd92

Sender Branch:

Branch Name: LPS-110508
Branch GIT ID: 4e0a690fe7815751d71ce0d809dec07904cd2b73

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 63 out of 77 jobs passed in 3 hours 20 minutes 59 seconds 940 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a3cca7261acc2992d2fdd7e0e0bc2ae8aac1c14b

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: f449d2b173145eac4a8dbaedde4c9ffc84086a5a

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 63 out of 77 jobs PASSED

14 Failed Jobs:

63 Successful Jobs:
For more details click here.

Failures unique to this pull:

  6. ...

For upstream results, click here.

@dacousalr
Copy link
Owner

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 32 out of 34 jobs passed in 3 hours 21 minutes 32 seconds 778 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d2f64d83a073182866857d86bc9b06c3555fccc2

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: f449d2b173145eac4a8dbaedde4c9ffc84086a5a

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 32 out of 34 jobs PASSED
32 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #366958
           [exec] * What went wrong:
     [exec] A problem was found with the configuration of task ':util:portal-tools-service-builder:jar'.
     [exec] > File '/opt/dev/projects/github/liferay-portal/modules/util/portal-tools-service-builder/bnd.bnd' specified for property '$1' does not exist.
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskValidationException: A problem was found with the configuration of task ':util:portal-tools-service-builder:jar'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.report(ValidatingTaskExecuter.java:72)
     [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:108)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveBeforeExecutionOutputsTaskExecuter.execute(ResolveBeforeExecutionOutputsTaskExecuter.java:67)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveAfterPreviousExecutionStateTaskExecuter.execute(ResolveAfterPreviousExecutionStateTaskExecuter.java:46)
     [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:94)
     [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:95)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)

For upstream results, click here.

@balazssk
Copy link
Author

The test:relevant issue looks like https://liferay.slack.com/archives/C04D8HMEF/p1585121492001200

hey all, in todays master, if we execute gradlew clean deploy it will remove the bnd for that module. So….mostly FYI

@dacousalr
Copy link
Owner

Yes, it is very likely. I will re-launch the relevant tests tomorrow. If they pass, I will do ci:forward

@dacousalr
Copy link
Owner

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 34 out of 34 jobs passed in 1 hour 11 minutes 23 seconds 774 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e4a8566ba9add6f6093029581845d16c831b6934

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: f449d2b173145eac4a8dbaedde4c9ffc84086a5a

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 34 out of 34 jobs PASSED
34 Successful Jobs:
For more details click here.

@dacousalr
Copy link
Owner

ci:forward

1 similar comment
@dacousalr
Copy link
Owner

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#86841

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 5 seconds 576 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 789aebc2aa941b0ea2cebe1ade1a09972d10cd92

Sender Branch:

Branch Name: LPS-110508
Branch GIT ID: 4e0a690fe7815751d71ce0d809dec07904cd2b73

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@balazssk @liferay-continuous-integration @dacousalr