Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] LPS-123159 | master #289

Closed
wants to merge 3 commits into from
Closed

[TS] LPS-123159 | master #289

wants to merge 3 commits into from

Conversation

bakayattila
Copy link

Hi @dacousalr,

I reviewed the modification and made the test case according to our discussion.
Could you review it?

https://issues.liferay.com/browse/LPS-123159

Best,
Attila

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@bakayattila
Copy link
Author

ci:test:sf

@bakayattila
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cf5f0b9de37165381f866420408e6e7e7e014939

Sender Branch:

Branch Name: LPS-123159
Branch GIT ID: 7209cc0354cb16d093c6fc9adf8563e7c7c2608f

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#4582
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:dacousalr#289
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - bakayattila > dacousalr - PR#289 - 2020-11-24[05:49:32]
Spira Jenkins Build:publish-spira-report#8936

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 24 jobs passed in 2 hours 40 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cf5f0b9de37165381f866420408e6e7e7e014939

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 24 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 87121f2:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #445338

      Please fix semantic versioning on bakayattila/LPS-123159

           [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.document.library.constants             MINOR      1.1.0      1.1.0      1.2.0      VERSION INCREASE REQUIRED
     [exec] 	+   class      com.liferay.document.library.constants.DLContentTypes
     [exec] 		+   field      EXTERNAL_VIDEO
     [exec] 			+   access     final
     [exec] 			+   access     static
     [exec] 			+   constant   application/vnd+liferay.external.video+html
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     <init>()
     [exec] 			+   return     void
     [exec] 		+   method     clone()
     [exec] 			+   access     protected
     [exec] 			+   return     java.lang.Object
     [exec] 		+   method     equals(java.lang.Object)
     [exec] 			+   return     boolean
     [exec] 		+   method     finalize()
     [exec] 			+   access     protected
     [exec] 			+   return     void
     [exec] 		+   method     hashCode()
     [exec] 			+   return     int
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.document.library.api-7.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.document.library.api/6.4.5/909b875580f4c1133dfb760354b62d050a467de2/com.liferay.document.library.api-6.4.5.jar

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#7294
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:dacousalr#289
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - bakayattila > dacousalr - PR#289 - 2020-11-24[06:35:04]
Spira Jenkins Build:publish-spira-report#10001

@dacousalr
Copy link
Owner

Just started reviewing :)

@dacousalr
Copy link
Owner

Pull request submitted to #290. See changes here.

@dacousalr dacousalr closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@bakayattila @liferay-continuous-integration @dacousalr