New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-127734 Wrong default language in Web Content #302
Conversation
… the one from the site. In case the article already exists, then the default language is taken from the current article
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ci:test:sf |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-127734 1 Successful Jobs:For more details click here. |
ci:test:relevant |
Jenkins Build:test-portal-source-format#4548 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#7727 |
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously passed test suites: |
All required test suite(s) passed. |
Pull request has been successfully forwarded to brianchandotcom#98700 |
Hi @dacousalr ,
After your proposal in PTR-2244, I realized our code was already trying to do what you suggested as solution:
However, the condition was not right, since _article is not null at that point. So instead of checking the value of _article's variable to know whether we are creating or editing an article, I'm checking the articleId, which is null when creating, but it contains some value when updating.
Let me know if you have further questions about this pull request.
Thanks.
Regards.