Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-127734 Wrong default language in Web Content #302

Closed
wants to merge 1 commit into from

Conversation

antonio-ortega
Copy link

Hi @dacousalr ,

After your proposal in PTR-2244, I realized our code was already trying to do what you suggested as solution:

  • New articles => Default locale is the site's default locale
  • Existing articles => Default locale is taken from the article

However, the condition was not right, since _article is not null at that point. So instead of checking the value of _article's variable to know whether we are creating or editing an article, I'm checking the articleId, which is null when creating, but it contains some value when updating.

Let me know if you have further questions about this pull request.

Thanks.

Regards.

… the one from the site. In case the article already exists, then the default language is taken from the current article
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@dacousalr
Copy link
Owner

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9272e31bc0297f9ad114de2c3a67f68aec8ea3cd

Sender Branch:

Branch Name: LPS-127734
Branch GIT ID: 25d97dc2af9d87ad3f74ce8776e03fe7b4428d97

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@dacousalr
Copy link
Owner

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 1 hour 46 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9272e31bc0297f9ad114de2c3a67f68aec8ea3cd

Upstream Comparison:

Branch GIT ID: 9272e31bc0297f9ad114de2c3a67f68aec8ea3cd
Jenkins Build URL: Acceptance Upstream DXP (master) #1542

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 23 out of 23 jobs PASSED
23 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@dacousalr
Copy link
Owner

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#98700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants