fix: resolve with hook error

dadi · Nov 20, 2018 · 68cebf5 · 68cebf5
1 parent f82375e
commit 68cebf5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/dadi/lib/model/collections/get.js b/dadi/lib/model/collections/get.js
@@ -101,10 +101,16 @@ function get ({
           },
           (error, resultsAfterHooks) => {
             if (error) {
-              error.hook = this.settings.hooks.afterGet
+              let hook = new Hook({
+                hook: this.settings.hooks.afterGet[0]
+              }, 'afterGet')
 
               logger.error({ module: 'model' }, error)
-              return reject(error)
+
+              return resolve({
+                results: hook.formatError(error[0].code),
+                metadata: {}
+              })
             }
 
             resolve(resultsAfterHooks)
@@ -126,8 +132,6 @@ function get ({
     ).then(results => {
       return {results, metadata}
     })
-  }).catch(err => {
-    return err
   })
 }
 

diff --git a/test/unit/model/hooks.js b/test/unit/model/hooks.js
@@ -1500,7 +1500,7 @@ describe('Hook', function () {
 
           hook.Hook.prototype.load.restore()
 
-          doc[0].code.indexOf('Cannot find module').should.be.above(0)
+          doc.results[0].details.indexOf('Cannot find module').should.be.above(0)
 
           done()
         })