Extend hooks config endpoint #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimlambie
reviewed
May 4, 2017
dadi/lib/index.js
Outdated
|
|
||
| return help.sendBackJSON(404, res, next)(null, {}) | ||
| return help.sendBackJSON(400, res, next)(null, {'error': 'Invalid method'}) |
There was a problem hiding this comment.
I think we could return a 405 here, Method Not Allowed
jimlambie
reviewed
May 4, 2017
dadi/lib/index.js
Outdated
|
|
||
| return help.sendBackJSON(200, res, next)(null, data) | ||
| return help.sendBackJSON(400, res, next)(null, {'error': 'Invalid method'}) |
There was a problem hiding this comment.
I think we could return a 405 here, Method Not Allowed
jimlambie
reviewed
May 4, 2017
test/acceptance/app.js
Outdated
| @@ -3223,7 +3223,7 @@ describe('Application', function () { | |||
|
|
|||
| it('should return 400 if request method is not supported', function (done) { | |||
| request(connectionString) | |||
| .put('/api/hooks/xx/config') | |||
| .put('/api/hooks') | |||
jimlambie
suggested changes
May 4, 2017
|
Totally! There were a few instances of |
jimlambie
approved these changes
May 29, 2017
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the hooks config endpoint (
/api/hooks/:hookName/config) to acceptPOST,PUTandDELETErequests to create, update and delete hooks, respectively. Acceptance tests are included.Close #254
@jimlambie I branched off
feat/media-endpoint, and so I made the PR with that branch as base. Let me know if that's an issue.Thanks!