Add default logic for service impl

daedafusion · Mar 14, 2017 · f730c8f · f730c8f
1 parent c0fc21b
commit f730c8f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/service-framework-core/src/main/java/com/daedafusion/sf/config/ManagedObjectDescription.java b/service-framework-core/src/main/java/com/daedafusion/sf/config/ManagedObjectDescription.java
@@ -48,7 +48,16 @@ public void setInfClass(String infClass)
 
     public String getImplClass()
     {
-        return implClass;
+        if(implClass != null)
+        {
+            return implClass;
+        }
+        else
+        {
+            // Return default by convention
+            int lastDot = getInfClass().lastIndexOf(".");
+            return String.format("%s.impl%sImpl", getInfClass().substring(0, lastDot), getInfClass().substring(lastDot));
+        }
     }
 
     public void setImplClass(String implClass)

diff --git a/service-framework-core/src/test/java/com/daedafusion/sf/BasicTest.java b/service-framework-core/src/test/java/com/daedafusion/sf/BasicTest.java
@@ -80,4 +80,13 @@ private ServiceConfiguration buildConfig()
 
         return config;
     }
+
+    @Test
+    public void testConventionFallback()
+    {
+        ManagedObjectDescription mod = new ManagedObjectDescription();
+        mod.setInfClass("com.test.framework.MyService");
+
+        assertThat(mod.getImplClass(), is("com.test.framework.impl.MyServiceImpl"));
+    }
 }