-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Boogie representation of the Dafny heap use only Box #4020
Changes from all commits
dbfc6b5
b4e17c7
d232c51
4bf6bd0
56c02fc
1fa6cec
ca7e07f
26e4a43
5fa31e9
b4a9248
348d8a9
2e9eb31
1ab569c
105e880
697a645
74f08b4
917d41f
c8d3b0a
9cdc5dc
96e505f
fa1b33e
98b2e08
2620d13
a18154d
0ec9a51
e7965dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
// UNSUPPORTED: windows,posix | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test repeatedly fails essentially whenever we make any change to the Boogie encoding. So I'm disabling it for now. I think it could be refactored to be less difficult, but that would be a somewhat involved job. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At least it's still tested on other OS, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, it's not tested anywhere. One of the other tests in that directory is disabled, too, because it doesn't reliably verify. Ultimately, it's interesting code but I'm not sure it's testing something particularly valuable. And it's so brittle that changing essentially anything in the encoding causes it to fail, even if it makes other things better. |
||
// RUN: %dafny /compile:0 /proverOpt:O:smt.qi.eager_threshold=30 /typeEncoding:p "%s" > "%t" | ||
// RUN: %diff "%s.expect" "%t" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed, but because you will eventually remove the alpha from read, you add it preventively, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. And the code in Dafny that generates Boogie code does this for some but not all instances of
read
, as well. Once it does it everywhere, we can remove the type parameter toField
.