Fix: Ghost diagnostics correctly updated when becoming empty #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -259,6 +259,17 @@ public class NotificationPublisher : INotificationPublisher { | |||
| }).ToArray(), | |||
| }); | |||
| } | |||
|
|
|||
| // If we don't have ghost state anymore, publish empty ghost diagnostics | |||
There was a problem hiding this comment.
Could you merge the two loops?
var uris == previousParams.Keys.Concat(params.Keys);
foreach (var uri in uris) {
var previous = previousParams.GetValueOrDefault(uri) ?? Enumerable<Range>.Empty();
var current = currentParams.GetValueOrDefault(uri) ?? Enumerable<Range>.Empty();
if (previous.SequenceEqual(current)) {
continue;
}
languageServer.TextDocument.SendNotification(new GhostDiagnosticsParams {
Uri = uri,
Version = state.Version,
Diagnostics = current.Select(r => new Diagnostic {
Range = r
}).ToArray(),
});
}
keyboardDrummer
approved these changes
Nov 8, 2023
|
Nice! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4693
I added a test that was previously failing.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.