chore: setup changie on Rust SDK #5676
Conversation
Add basic [Changie](https://changie.dev/) setup to Rust based on dagger#5408. Signed-off-by: Vasek - Tom C <tom@epitech.eu>
sdk/rust/CHANGELOG.md
Outdated
There was a problem hiding this comment.
Should I convert the old changelog to the new changie format?
There was a problem hiding this comment.
Feel free to do so, if it isn't too much of a bother. Otherwise we can just archive the old changelog
There was a problem hiding this comment.
I saw that all commits where on your personal repository, so I'll drop this changelog so we can start with a fresh one on Dagger repository :)
sdk/rust/.changie.yaml
Outdated
| ⬢ https://crates.io/crates/dagger-sdk | ||
| 📒 https://docs.rs/dagger-sdk/ |
There was a problem hiding this comment.
I wanted to add the exact release number but the format is major.minor.patch without v.
I can check on Changie if it's possible to trim the version number if that's important!
There was a problem hiding this comment.
It looks to be using gotemplates, so we could probably just strip the first character
There was a problem hiding this comment.
Yep it work, here's the output with a dry run for version 0.3.1
⬢ https://crates.io/crates/dagger-sdk/0.3.1
📒 https://docs.rs/dagger-sdk/0.3.1/dagger-sdk
Fixed in fd76c23
|
Yes is it, here is an example of command: You can also check our |
|
I'll apply the changes today or tomorrow and we can merge it after that :) |
Signed-off-by: Vasek - Tom C <tom@epitech.eu>
|
I merge that PR as soon as CI has finished :) |
|
I see a few issues with this PR:
|
My answer was:
Basically, all the commits are pointing to @kjuulh, and not our, if that's not a problem I can add old changelog but I thought it would be better to tag PR from our repository that splitting commits across repos.
Right, I wasn't sure which version I should take, should we start with 0.3.0 since it's the latest?
What is the best to do? @kjuulh do you want the Rust release to be part of our SDKs release or do you wanna keep doing the release yourself? |
|
It would be best if the rust sdk aligns with the existing release process for other sdks, that is as long as it is something I can trigger =D Version 0.3.0 is a good starting point, so we can just start off of that. The old changelogs aren't super necessary, as we've got quite limited consumers, feel free to start off from scratch if it is easier. If people want to read changelogs, they can go back to the archived repo and read the release notes for the older releases, or read them via. crates io, where they should be included as well. The only thing I need to do is fix the publish pipeline, it was disabled because it was too unstable I think. Rust is very finicky about releasing dependent crates (I've already fixed this issue), so I will attempt to fix the last parts missing for the publisher and we should be good to go. The only other thing is that I need to support bumping the versions in the crates as well, rust prefers if the |
Sounds good, I'll create a first version file then to pin this version!
Is that thing that can be integrated to our mage system? You can open a PR to add these changes for sure! |
|
@TomChv probably the only thing that is a bit iffy is that it needs to commit the changes afterwards. If so I may avoid doing it there and see if I can do it in another place. |
|
@kjuulh part of releasing the Engine & CLI, we also release the Go, Python, Node.js & Elixir SDKs. We use the same version across all artefacts so that users don't get confused about version mismatches. We had multiple situations when the different versions created confusion for our users (e.g. Go SDK I see two options:
What would you prefer @kjuulh? |
|
@gerhard i probably need to release it on my own then. As i may not always be available to fix issues that come up during the release process. |
|
Alright, we can keep changie for the consistency but I'll remove Rust from |
As discussed in dagger#5676, Rust will not be part of the SDK release process and will have its own pipeline. By extension, we shall not mention rust in `RELEASING.md` steps Signed-off-by: Vasek - Tom C <tom@epitech.eu>
|
Yep lets do that |
As discussed in #5676, Rust will not be part of the SDK release process and will have its own pipeline. By extension, we shall not mention Rust SDK in `RELEASING.md` steps Signed-off-by: Vasek - Tom C <tom@epitech.eu>
Add basic Changie setup to Rust based on #5408.