Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: clarify withMountedTemp docs that they are ephemeral #7281

Merged
merged 1 commit into from
May 6, 2024

Conversation

sipsma
Copy link
Contributor

@sipsma sipsma commented May 4, 2024

Just a doc string update, but something odd is happening when I run ./hack/make sdk:elixir:generate locally:

✘ DaggerElixirSdk.generate: Directory! 11.8s
! call function "Generate": process "/runtime" did not complete successfully: exit code: 2
┃ marshal: json: error calling MarshalJSON for type *dagger.Directory: input: container.from.withWorkdir.withDirectory.withExec.withExec.withExec.withServiceBinding.withEnvVariable.withMountedFile.withEnvVariable.withExec.withMountedSecret.withWorkd
┃                                                                                                                                                                                                                                                        
┃ Stdout:                                                                                                                                                                                                                                                
┃ Resolving Hex dependencies...                                                                                                                                                                                                                          
┃ Stderr:                                                                                                                                                                                                                                                
┃ eheap_alloc: Cannot allocate 976733209832459912 bytes of memory (of type "heap_frag").                                                                                                                                                                 
┃                                                                                                                                                                                                                                                        
┃ Crash dump is being written to: erl_crash.dump...beam/erl_term.h:1492:tag_val_def() Assertion failed: tag_val_def error                                                                                                                                
  ✘ Container.directory(path: "gen"): Directory! 1.4s
  ! process "mix deps.get" did not complete successfully: exit code: 255
    ✘ exec mix deps.get 1.4s
    ! process "mix deps.get" did not complete successfully: exit code: 255
    ┃ Resolving Hex dependencies...                                                                                                                                                                                                                      
    ┃ eheap_alloc: Cannot allocate 976733209832459912 bytes of memory (of type "heap_frag").                                                                                                                                                             
    ┃                                                                                                                                                                                                                                                    
    ┃ Crash dump is being written to: erl_crash.dump...beam/erl_term.h:1492:tag_val_def() Assertion failed: tag_val_def error                                                                                                                            

Error: response from query: input: dagger.sdk.elixir.generate resolve: call function "Generate": process "/runtime" did not complete successfully: exit code: 2

Stdout:
marshal: json: error calling MarshalJSON for type *dagger.Directory: input: container.from.withWorkdir.withDirectory.withExec.withExec.withExec.withServiceBinding.withEnvVariable.withMountedFile.withEnvVariable.withExec.withMountedSecret.withWorkdir

Stdout:
Resolving Hex dependencies...
Stderr:
eheap_alloc: Cannot allocate 976733209832459912 bytes of memory (of type "heap_frag").

Crash dump is being written to: erl_crash.dump...beam/erl_term.h:1492:tag_val_def() Assertion failed: tag_val_def error
Error: exit status 1
exit status 1

@wingyplus any ideas why it would be trying to allocate 976733209832459912 bytes of memory? 😂 I'm gonna have to download more RAM if it's actually needed.

Not a blocker if no easy fix, I can resort to just hand editing the file for now since it's just a doc string update.

@sipsma sipsma requested a review from jedevc May 4, 2024 21:35
@sipsma sipsma requested a review from a team as a code owner May 4, 2024 21:36
@wingyplus
Copy link
Contributor

@sipsma it might be an issue with the Erlang/OTP that I upgrade recently. Found that one on Mac arm cpu (M* cpu family) here. Simple fix would be downgrading it. Let me submit a fix within today. 🙇‍♂️

@wingyplus
Copy link
Contributor

wingyplus commented May 5, 2024

@sipsma Just see the discussion on that Erlang issue that it already fix in 26.2.4 (we used 26.2.3). So submit a fix by upgrading it instead at #7283. If you found any issue, please ping me in the GitHub or Discord, I'll help investigate more on this as soon as possible. 🙇

Signed-off-by: Erik Sipsma <erik@sipsma.dev>
@sipsma sipsma requested a review from a team as a code owner May 6, 2024 18:17
@sipsma
Copy link
Contributor Author

sipsma commented May 6, 2024

@wingyplus thank you so much for the quick fix! Works now 🎉

@sipsma
Copy link
Contributor Author

sipsma commented May 6, 2024

There are some failures/cancelled-gha jobs here but they are due to some infra changes made a bit ago. Given this is just a doc string update I'm gonna go ahead and merge.

@sipsma sipsma merged commit de39db1 into dagger:main May 6, 2024
80 of 84 checks passed
vikram-dagger pushed a commit to vikram-dagger/dagger that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants