Allow tempdir/tempfile as instance methods #242
Conversation
This patch allows using methods tempdir/tempfile as instance methods too, in addition to class methods and simple functions. When used as instance methods, the underlying instance MUST represent a directory. In this case, it is used to override the DIR option of File::Temp.
|
One thing, to be transparent: any If this not the wanted behavior it's easy (although not trivial) to change this, although in this case I would expect the programmer to use the class method or the exported function. |
|
Thanks. I'm a bit busy with family obligations lately, but I'll try to make time this weekend or next week to review it. |
No worries and no pressure - it's voluntary open source (and it's not a security bug) 😄 |
There was a problem hiding this comment.
This looks great -- I wish I'd done this originally. I have a couple minor requests. Also, I'd like to see a test of the leading options hash to get more coverage of the refactored code paths. (Doing a coverage test on the new code looking for other gaps would be a good idea.)
|
I'll do the requested changes and try to think about additional tests for improving coverage, thanks for looking into it |
|
Thank you very much! Shipping a dev release to CPAN now. |
This patch allows using methods tempdir/tempfile as instance methods too, in addition to class methods and simple functions.
When used as instance methods, the underlying instance MUST represent a directory. In this case, it is used to override the DIR option of File::Temp.
The documentation makes a reference to the version when the added behavior is made available, I don't know if this wanted.
This pull request addresses #115