add tick tooltip info for skipped ticks due to run key idempotence (#…

…7131)
dagster-io · Mar 22, 2022 · 291fbf5 · 291fbf5
1 parent b17183e
commit 291fbf5
Show file tree

Hide file tree

Showing 17 changed files with 50 additions and 8 deletions.
diff --git a/js_modules/dagit/packages/core/src/graphql/schema.graphql b/js_modules/dagit/packages/core/src/graphql/schema.graphql
diff --git a/js_modules/dagit/packages/core/src/instance/types/InstanceSchedulesQuery.ts b/js_modules/dagit/packages/core/src/instance/types/InstanceSchedulesQuery.ts
diff --git a/js_modules/dagit/packages/core/src/instance/types/InstanceSensorsQuery.ts b/js_modules/dagit/packages/core/src/instance/types/InstanceSensorsQuery.ts
diff --git a/js_modules/dagit/packages/core/src/instigation/InstigationTick.tsx b/js_modules/dagit/packages/core/src/instigation/InstigationTick.tsx
@@ -39,7 +39,7 @@ export const TickTag: React.FC<{
       if (!tick.runIds.length) {
         return <TagWIP intent="primary">Requested</TagWIP>;
       }
-      return (
+      const tag = (
         <>
           <TagWIP intent="primary" interactive>
             <ButtonLink underline="never" onClick={() => setOpen(true)}>
@@ -61,15 +61,35 @@ export const TickTag: React.FC<{
           </DialogWIP>
         </>
       );
+      if (tick.runKeys.length > tick.runIds.length) {
+        const message = `${tick.runKeys.length} runs requested, but ${
+          tick.runKeys.length - tick.runIds.length
+        } skipped because the runs already exist for those requested keys.`;
+        return (
+          <Tooltip position="right" content={message}>
+            {tag}
+          </Tooltip>
+        );
+      }
+      return tag;
+
     case InstigationTickStatus.SKIPPED:
-      if (!tick.skipReason) {
-        return <TagWIP intent="warning">Skipped</TagWIP>;
+      if (tick.runKeys) {
+        const message = `${tick.runKeys.length} runs requested, but skipped because the runs already exist for the requested keys.`;
+        return (
+          <Tooltip position="right" content={message}>
+            <TagWIP intent="warning">Skipped</TagWIP>
+          </Tooltip>
+        );
       }
-      return (
-        <Tooltip position="right" content={tick.skipReason} targetTagName="div">
-          <TagWIP intent="warning">Skipped</TagWIP>
-        </Tooltip>
-      );
+      if (tick.skipReason) {
+        return (
+          <Tooltip position="right" content={tick.skipReason} targetTagName="div">
+            <TagWIP intent="warning">Skipped</TagWIP>
+          </Tooltip>
+        );
+      }
+      return <TagWIP intent="warning">Skipped</TagWIP>;
     case InstigationTickStatus.FAILURE:
       if (!tick.error) {
         return <TagWIP intent="danger">Failure</TagWIP>;
@@ -186,6 +206,7 @@ export const TICK_TAG_FRAGMENT = gql`
     timestamp
     skipReason
     runIds
+    runKeys
     error {
       ...PythonErrorFragment
     }

diff --git a/js_modules/dagit/packages/core/src/instigation/types/InstigationStateFragment.ts b/js_modules/dagit/packages/core/src/instigation/types/InstigationStateFragment.ts
diff --git a/js_modules/dagit/packages/core/src/instigation/types/SelectedTickQuery.ts b/js_modules/dagit/packages/core/src/instigation/types/SelectedTickQuery.ts
diff --git a/js_modules/dagit/packages/core/src/instigation/types/TickHistoryQuery.ts b/js_modules/dagit/packages/core/src/instigation/types/TickHistoryQuery.ts
diff --git a/js_modules/dagit/packages/core/src/instigation/types/TickTagFragment.ts b/js_modules/dagit/packages/core/src/instigation/types/TickTagFragment.ts
diff --git a/js_modules/dagit/packages/core/src/runs/types/SchedulerInfoQuery.ts b/js_modules/dagit/packages/core/src/runs/types/SchedulerInfoQuery.ts
diff --git a/js_modules/dagit/packages/core/src/schedules/types/RepositorySchedulesFragment.ts b/js_modules/dagit/packages/core/src/schedules/types/RepositorySchedulesFragment.ts
diff --git a/js_modules/dagit/packages/core/src/schedules/types/ScheduleFragment.ts b/js_modules/dagit/packages/core/src/schedules/types/ScheduleFragment.ts
diff --git a/js_modules/dagit/packages/core/src/schedules/types/ScheduleRootQuery.ts b/js_modules/dagit/packages/core/src/schedules/types/ScheduleRootQuery.ts
diff --git a/js_modules/dagit/packages/core/src/schedules/types/SchedulesRootQuery.ts b/js_modules/dagit/packages/core/src/schedules/types/SchedulesRootQuery.ts
diff --git a/js_modules/dagit/packages/core/src/sensors/types/SensorFragment.ts b/js_modules/dagit/packages/core/src/sensors/types/SensorFragment.ts
diff --git a/js_modules/dagit/packages/core/src/sensors/types/SensorRootQuery.ts b/js_modules/dagit/packages/core/src/sensors/types/SensorRootQuery.ts
diff --git a/js_modules/dagit/packages/core/src/sensors/types/SensorsRootQuery.ts b/js_modules/dagit/packages/core/src/sensors/types/SensorsRootQuery.ts
diff --git a/python_modules/dagster-graphql/dagster_graphql/schema/instigation.py b/python_modules/dagster-graphql/dagster_graphql/schema/instigation.py
@@ -99,6 +99,7 @@ class GrapheneInstigationTick(graphene.ObjectType):
     status = graphene.NonNull(GrapheneInstigationTickStatus)
     timestamp = graphene.NonNull(graphene.Float)
     runIds = non_null_list(graphene.String)
+    runKeys = non_null_list(graphene.String)
     error = graphene.Field(GraphenePythonError)
     skipReason = graphene.String()
     cursor = graphene.String()
@@ -115,6 +116,7 @@ def __init__(self, _, tick):
             status=tick.status,
             timestamp=tick.timestamp,
             runIds=tick.run_ids,
+            runKeys=tick.run_keys,
             error=tick.error,
             skipReason=tick.skip_reason,
             originRunIds=tick.origin_run_ids,