add tick tooltip info for skipped ticks due to run key idempotence #7131
+50
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). dagster – ./docs/next🔍 Inspect: https://vercel.com/elementl/dagster/FBPFsoFCckXmMWj2fxWWdmQQWtJN [Deployment for 9fb4d75 canceled] dagit-storybook – ./js_modules/dagit/packages/ui🔍 Inspect: https://vercel.com/elementl/dagit-storybook/AkqaZcaVbovZzkt4fi8xcVp8PBiZ [Deployment for 9fb4d75 canceled] |
prha
force-pushed
the
prha/run_key_tick_info
branch
from
4b66bbe
to
9fb4d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context: #3726
User getting degraded DB performance as each sensor evaluation was looping on an increasing number of run fetches for idempotence. #7094 was just landed to batch the run fetches, but this PR is about surfacing some of this idempotence info on a per-tick basis so that users have a chance of noticing that they might want to rely less on run_keys.
Screen.Recording.2022-03-18.at.10.54.55.AM.mov
Test Plan
BK