[refactor] NodeDefiniton.iterate_solid_defs -> iterate_op_defs (#12336)

### Summary & Motivation

Rename NodeDefinition.iterate_solid_defs -> iterate_node_defs

### How I Tested These Changes

BK

python_modules/dagster/dagster/_core/definitions/asset_group.py

@@ -486,7 +486,7 @@ def _validate_resource_reqs_for_asset_group(
         present_resource_keys = present_resource_keys.union(provided_resource_keys)
 
         required_resource_keys: Set[str] = set()
-        for op_def in asset_def.node_def.iterate_solid_defs():
+        for op_def in asset_def.node_def.iterate_op_defs():
             required_resource_keys.update(set(op_def.required_resource_keys or {}))
         missing_resource_keys = list(set(required_resource_keys) - present_resource_keys)
         if missing_resource_keys:

python_modules/dagster/dagster/_core/definitions/graph_definition.py

@@ -355,9 +355,9 @@ def iterate_node_defs(self) -> Iterator[NodeDefinition]:
         for outer_node_def in self._node_defs:
             yield from outer_node_def.iterate_node_defs()
 
-    def iterate_solid_defs(self) -> Iterator["OpDefinition"]:
+    def iterate_op_defs(self) -> Iterator["OpDefinition"]:
         for outer_node_def in self._node_defs:
-            yield from outer_node_def.iterate_solid_defs()
+            yield from outer_node_def.iterate_op_defs()
 
     def iterate_node_handles(
         self, parent_node_handle: Optional[NodeHandle] = None

python_modules/dagster/dagster/_core/definitions/node_definition.py

@@ -156,7 +156,7 @@ def iterate_node_defs(self) -> Iterable["NodeDefinition"]:
         ...
 
     @abstractmethod
-    def iterate_solid_defs(self) -> Iterable["OpDefinition"]:
+    def iterate_op_defs(self) -> Iterable["OpDefinition"]:
         ...
 
     @abstractmethod

python_modules/dagster/dagster/_core/definitions/op_definition.py

@@ -264,7 +264,7 @@ def all_dagster_types(self) -> Iterator[DagsterType]:
     def iterate_node_defs(self) -> Iterator[NodeDefinition]:
         yield self
 
-    def iterate_solid_defs(self) -> Iterator["OpDefinition"]:
+    def iterate_op_defs(self) -> Iterator["OpDefinition"]:
         yield self
 
     T_Handle = TypeVar("T_Handle", bound=Optional[NodeHandle])

python_modules/dagster/dagster_tests/asset_defs_tests/test_asset_group.py

@@ -668,7 +668,7 @@ def y(e, f):
     job = AssetGroup([foo, x, y], resource_defs={"io_manager": io_manager_def}).build_job("job")
 
     # should produce a job with foo(a,b,c,d,f) -> x -> foo(e,g) -> y -> foo(h)
-    assert len(list(job.graph.iterate_solid_defs())) == 5
+    assert len(list(job.graph.iterate_op_defs())) == 5
     result = job.execute_in_process()
 
     assert _all_asset_keys(result) == {AssetKey(x) for x in "a,b,c,d,e,f,g,h,x,y".split(",")}
@@ -735,7 +735,7 @@ def y(b, c):
     job = AssetGroup([foo, x, y], resource_defs={"io_manager": io_manager_def}).build_job("job")
 
     # should produce a job with foo -> x -> foo -> y -> foo
-    assert len(list(job.graph.iterate_solid_defs())) == 5
+    assert len(list(job.graph.iterate_op_defs())) == 5
     result = job.execute_in_process()
 
     assert _all_asset_keys(result) == {AssetKey(x) for x in "a,b,c,d,e,f,x,y".split(",")}
@@ -795,7 +795,7 @@ def foo_prime(context, a, b):
     ).build_job("job")
 
     # should produce a job with foo -> foo_prime -> foo_2 -> foo_prime_2
-    assert len(list(job.graph.iterate_solid_defs())) == 4
+    assert len(list(job.graph.iterate_op_defs())) == 4
 
     result = job.execute_in_process()
     assert result.output_for_node("foo", "a") == 1