Skip to content

Commit

Permalink
Support multiple search terms in run history url
Browse files Browse the repository at this point in the history
Summary: Previously, we could only specify one search term in the runs history URL, such as `/runs?q=id:10`. Now we can specify multiple comma seperated search terms, such as `/runs?q=id:10,mode:default`.

Test Plan: {F40049}

Reviewers: #ft, bengotow, alangenfeld

Reviewed By: #ft, alangenfeld

Differential Revision: https://dagster.phacility.com/D1066
  • Loading branch information
helloworld committed Sep 20, 2019
1 parent 4f82173 commit c7b7913
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
8 changes: 8 additions & 0 deletions js_modules/dagit/src/TokenizingField.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ function findProviderByToken(token: string, providers: SuggestionProvider[]) {
return providers.find(p => p.token.toLowerCase() === token.toLowerCase());
}

export function tokenizedValuesListFromString(
str: string,
providers: SuggestionProvider[]
) {
const tokens = str.split(",");
return tokens.map(token => tokenizedValueFromString(token, providers));
}

export function tokenizedValueFromString(
str: string,
providers: SuggestionProvider[]
Expand Down
4 changes: 2 additions & 2 deletions js_modules/dagit/src/runs/RunHistory.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import {
TokenizingField,
TokenizingFieldValue,
SuggestionProvider,
tokenizedValueFromString
tokenizedValuesListFromString
} from "../TokenizingField";
import { HighlightedCodeBlock } from "../HighlightedCodeBlock";
import { Link } from "react-router-dom";
Expand Down Expand Up @@ -196,7 +196,7 @@ export default class RunHistory extends React.Component<
this.state = {
sort: RunSort.START_TIME_DSC,
search: props.initialSearch
? [tokenizedValueFromString(props.initialSearch, suggestions)]
? tokenizedValuesListFromString(props.initialSearch, suggestions)
: [],
statuses: AllRunStatuses
};
Expand Down

0 comments on commit c7b7913

Please sign in to comment.