fix #9193: add retry policy to @asset and @multi_asset #10150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adam-bloom is attempting to deploy a commit to the Elementl Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dpeng817
reviewed
Oct 21, 2022
|
@dpeng817 any chance of getting this in this week's release? I'd love to be able to add this back to my assets (that I recently migrated from ops). |
sryza
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adds the capability to set retry policies on assets and multi_assets.
How I Tested These Changes
I haven't yet. Last time I tried to use a development version of dagster libraries in my user code development environment, I couldn't get dagit to start. Happy to try again if needed!
I didn't see any unit tests on the asset decorators either...Found them! Let me make some updates.