Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagstermill] Add retry_policy to dagstermill asset #10577

Merged
merged 2 commits into from Nov 17, 2022

Conversation

nickvazz
Copy link
Contributor

Summary & Motivation

Allow dagstermill assets to have retry policies

How I Tested These Changes

#10150

@vercel
Copy link

vercel bot commented Nov 17, 2022

@nickvazz is attempting to deploy a commit to the Elementl Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
dagit-storybook ⬜️ Ignored (Inspect) Nov 17, 2022 at 5:15PM (UTC)

@nickvazz nickvazz changed the title Add retry_policy to dagstermill asset [dagstermill] Add retry_policy to dagstermill asset Nov 17, 2022
@sryza
Copy link
Contributor

sryza commented Nov 17, 2022

@jamiedemaria mind taking a look?

Copy link
Contributor

@jamiedemaria jamiedemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the contribution

@jamiedemaria
Copy link
Contributor

hey @nickvazz looks like some of our formatting checks are failing in CI. Can you run make black and make isort from the main dagster folder?

Copy link
Contributor

@jamiedemaria jamiedemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to run the isort and black commands and then all good to go

@jamiedemaria jamiedemaria merged commit f888e48 into dagster-io:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants