Fix custom tz/cron schedule ignored in build_schedule_from_partitioned_job #22015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @clairelin135 and the rest of your teammates on |
clairelin135
changed the title
clairelin135
force-pushed
the
05-21-claire/fix-tz-being-ignored-in-schedule
branch
from
1ba3140
to
b0a4d04
Compare
sryza
reviewed
May 31, 2024
There was a problem hiding this comment.
Sorry I've been slow to get to this because I've been waffling on whether it makes sense to allow overriding these properties for time-partitioned assets.
My line of reasoning has been: the main point of this function is to infer these properties from the partitioning on the assets, so that they don't need to be specified redundantly by the user. In the situations where someone would want to set these properties, should they just be using @schedule directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, logic in
build_schedule_from_partitioned_jobthat infers partitions defs from the assets when a partitions def is not defined on the job would ignore any custom tz/cron schedule provided. This PR fixes.A different code path in the same function that evaluates jobs with a partitions def would raise an error when providing a custom tz/cron schedule. This PR adjusts this code path to accept these params for parity.