Definitions.merge #22035
Merged
Definitions.merge #22035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrockn
approved these changes
May 22, 2024
|
|
||
| with pytest.raises( | ||
| DagsterInvariantViolationError, | ||
| match="Definitions objects 0 and 1 both have a resource with key 'resource1'", |
There was a problem hiding this comment.
wording around "0 and 1" slightly goofy.
Slightly better might be:
"Trying to merge definitions with resources {"foo", "bar"} and {"bar", "baaz"}. {"bar"} conflicts"
or something
There was a problem hiding this comment.
Oops saw this and then forgot about it and then merged. Going to handle it in a followup.
There was a problem hiding this comment.
No problem at all. Just a recommendation.
sryza
force-pushed
the
definitions-merge-still-validate
branch
from
1681396
to
ebcefd4
Compare
sryza
force-pushed
the
definitions-merge-still-validate
branch
from
ebcefd4
to
bb89bd4
Compare
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
## Summary & Motivation There are diverse situations where it's useful to be able to pass around collections of definitions. Doing this in Dagster right now is quite awkward. Relevant situations: - Writing a factory that returns a few assets, a few checks, and a job that executes them together. - A submodule defines a few assets, a job, and a schedule. A different submodule does the same. They should all be in the same code location. - dagster-io#21387 (comment) - https://github.com/dagster-io/internal/discussions/8216 Unlike the [prior version of this PR](dagster-io#21746), this PR does _not_ turn `Definitions` into a "dumb" data class. I.e. it still validates that all assets and jobs can be bound, at construction time. ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
There are diverse situations where it's useful to be able to pass around collections of definitions. Doing this in Dagster right now is quite awkward.
Relevant situations:
Unlike the prior version of this PR, this PR does not turn
Definitionsinto a "dumb" data class. I.e. it still validates that all assets and jobs can be bound, at construction time.How I Tested These Changes