[bugfix] Show actual creation timestamp instead of start_time in runs table
#22788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @smackesey and the rest of your teammates on |
smackesey
changed the title
smackesey
force-pushed
the
sean/backfill-runs-sorting
branch
2 times, most recently
from
ff6e2fc
to
86dc60d
Compare
smackesey
changed the title
start_time in runs table
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit fc8374e. |
smackesey
force-pushed
the
sean/backfill-runs-sorting
branch
2 times, most recently
from
1a82012
to
b880fb1
Compare
|
Addressing backfill sorting issue from Foundations standup today. Tagged:
|
alangenfeld
approved these changes
Jul 1, 2024
| @@ -586,6 +587,10 @@ def resolve_updateTime(self, graphene_info: ResolveInfo): | |||
| run_record = self._get_run_record(graphene_info.context.instance) | |||
| return datetime_as_float(run_record.update_timestamp) | |||
|
|
|||
| def resolve_creationTime(self, graphene_info: ResolveInfo): | |||
| run_record = self._get_run_record(graphene_info.context.instance) | |||
There was a problem hiding this comment.
looking at __init__ it seems we are always constructed with record now, seems like we can remove this _get_run_record jonx
There was a problem hiding this comment.
good point #22805
smackesey
force-pushed
the
sean/backfill-runs-sorting
branch
from
b880fb1
to
fc8374e
Compare
bengotow
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
A recent user inquiry about the sorting of runs in the backfill runs table
(https://dagsterlabs.slack.com/archives/C064933ANQL/p1719328567183329) led to the discovery that what is listed as the "Create date" in the runs table UI is not actually the "Create time" of the underlying run record, but rather the
start_time(when the run was launched) if it was defined, or if not theupdate_time.This is both inaccurate and also causes the sorting in the table to be inscrutable in some cases, where there is a subtle deviation from sorting by "Created date".
This PR updates the UI to use the run record
creation_timeinstead ofstart_timeorupdated_time.creation_timeis always defined since it is set on record creation. This change both fixes the inaccuracy on the runs page and results in more straightforward sorting.Note that creation time was not exposed on the
GrapheneRunGQL type so it is added here.How I Tested These Changes
Viewed backfill runs page linked by user in shadow dagit with this applied, confirmed sorting was fixed.
Before:
After: