Change dask executor config depending on if using job #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/elementl/dagster/GLSke3a6kLkB8RgcHeC8mSzR76wj [Deployment for 4d3a1ae canceled] |
alangenfeld
reviewed
Dec 1, 2021
alangenfeld
previously requested changes
Dec 1, 2021
dpeng817
force-pushed
the
dask_executor_fix
branch
from
8efc6be
to
5d4dc7b
Compare
Right, but are we sure we're okay with that? Could the process where this code runs potentially be a place where we aren't okay with loading the definition? |
the host only code paths are separated - especially from this dask executor specific code. I think its fine. |
dpeng817
force-pushed
the
dask_executor_fix
branch
from
5d4dc7b
to
b3a8b0f
Compare
dpeng817
force-pushed
the
dask_executor_fix
branch
from
b3a8b0f
to
4d3a1ae
Compare
gibsondan
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check that I chose here is maybe not the correct one. If someone has a pipeline with a mode default, and put the dask executor on it, then we might run into a problem.